Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump the cryptography version to 41.0.6 #16322

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Bump the cryptography version to 41.0.6 #16322

merged 1 commit into from
Dec 4, 2023

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Dec 4, 2023 •
edited
Loading

What does this PR do?

  • Bump the cryptography version to 41.0.6

Motivation

https://github.com/DataDog/image-vuln-scans/issues/1241

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@FlorentClarret FlorentClarret requested review from a team as code owners December 4, 2023 08:20
@FlorentClarret FlorentClarret changed the base branch from master to 7.50.x December 4, 2023 08:20
@codecov Codecov
Copy link

codecov bot commented Dec 4, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (7.50.x@5b6935d). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head a0488b4 differs from pull request most recent head bf3d265. Consider uploading reports for the commit bf3d265 to get more accurate results

Additional details and impacted files
Flag Coverage Δ
cisco_aci 95.31% <0.00%> (?)
datadog_checks_base 89.63% <0.00%> (?)
http_check 95.28% <0.00%> (?)
kubelet 90.90% <0.00%> (?)
mysql 87.36% <0.00%> (?)
tls 92.07% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

alopezz
alopezz previously approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@alopezz alopezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 as soon as the agent build completes successfully.

@FlorentClarret FlorentClarret removed the request for review from a team December 4, 2023 08:36
@FlorentClarret FlorentClarret changed the title florentclarret/7.50/bump crypto Bump the cryptography version to 41.0.6 Dec 4, 2023
@FlorentClarret
Copy link
Member Author

Note: the release-hash-check was triggered because I initially opened the PR for master instead of 7.50.x

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

Test Results

     34 files       34 suites   21m 26s ⏱️
1 510 tests 1 492 ✔️   18 💤 0 ❌
6 152 runs  5 388 ✔️ 764 💤 0 ❌

Results for commit a0488b4.

clamoriniere
clamoriniere reviewed Dec 4, 2023
View reviewed changes
Copy link
Contributor

@clamoriniere clamoriniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smal question before approving

kubelet/changelog.d/16322.fixed Outdated
@@ -0,0 +1 @@
Bump the cryptography version to 41.0.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we get this changelog in kubelet check because it has been updated in the datadog_check_base?
else I don't see other file change in this check.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I missed that, sounds like our changelog command has a bug. I'll drop this file, really sorry for the noise

nenadnoveljic
nenadnoveljic previously approved these changes Dec 4, 2023
View reviewed changes
@FlorentClarret
Copy link
Member Author

I dropped a changelog file, the CI was green, merging

@FlorentClarret FlorentClarret merged commit 3a40963 into 7.50.x Dec 4, 2023
11 of 12 checks passed
@FlorentClarret FlorentClarret deleted the florentclarret/7.50/bump_crypto branch December 4, 2023 11:00
@FlorentClarret FlorentClarret mentioned this pull request Dec 4, 2023
Merged
3 tasks
FlorentClarret added a commit that referenced this pull request Dec 4, 2023
@FlorentClarret
Bump the cryptography version to 41.0.6 (#16322)
e628a3f
@FlorentClarret FlorentClarret mentioned this pull request Dec 4, 2023
Merged
3 tasks
FlorentClarret added a commit that referenced this pull request Dec 4, 2023
@FlorentClarret
Port the cryptography bump to master (#16326)
8949364 
* Bump the cryptography version to 41.0.6 (#16322)

* Release integrations after the cryptography bump (#16325)

* [Release] Bumped cisco_aci version to 2.4.2

* [Release] Bumped datadog_checks_base version to 34.3.1

* [Release] Bumped http_check version to 9.2.3

* [Release] Bumped mysql version to 11.4.1

* [Release] Bumped tls version to 2.13.2

* [Release] Update metadata
@iliakur iliakur mentioned this pull request Dec 19, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clamoriniere clamoriniere clamoriniere left review comments

@nenadnoveljic nenadnoveljic nenadnoveljic left review comments

@alopezz alopezz alopezz left review comments

Assignees
No one assigned
Labels
base_package dependencies documentation integration/cisco_aci integration/http_check integration/kubelet integration/mysql integration/tls team/agent-integrations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FlorentClarret @clamoriniere @nenadnoveljic @alopezz